Preserve full registry API path #2642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
syphar
approved these changes
Oct 20, 2024
Member
syphar
left a comment
syphar
left a comment
There was a problem hiding this comment.
I'm not sure about the use-case here, but I see that there is an inconsistency.
Thinking about it, the search functionality would also belong into the registry-api, but this can be done separately.
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Url::joinwill truncate the entire path if an absolute path is joined into it.Given a custom registry API:
The query will hit this URL:
Instead of:
Not quite sure if this is desired behavior or a bug but this seems inline with other uses of the registry API in
RegistryApiwhere the full path is preserved.