cdn: additional support for Fastly caching headers & invalidation #3013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
Nov 21, 2025
Member
|
Looks good to me, thanks! |
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is ready for a first review.
For now I tried to keep both CloudFront & Fastly alive to be able to test fastly more deeply in production. But I also didn't invest too much time into fleshing out a design / refactor that incorporates both, since we'll drop CloudFront when all is fine.
The idea is to deploy this, then configure the fastly service SIDs, the API token and then see how it errors, and if invalidation works on https://fastly.docs.rs/.
I tried to add many explanations & documentation links where needed, but I'm happy to add more.
Main conceptual differences:
/{krate}/*and/crate/{krate}/*, we have to explicitly tag the content for fastly to be able to purge it later. My guess is that this is why it's so fast :)