Deal with nullability of owner data #839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nemo157
force-pushed
the
fix-owners
branch
2 times, most recently
from
e90e1c7 to
03271dc
Compare
jyn514
approved these changes
Jun 18, 2020
Member
jyn514
left a comment
jyn514
left a comment
There was a problem hiding this comment.
Tested this locally with a crate that had a null owner.name and everything works fine.
Member
|
For reference: this is a follow-up to #813 that fixes some bugs I found while testing locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the owner fields can be
null, depending on what data was available from the Github API when crates.io scraped it. The old implementation turned any null field into an empty string, which still seems like the best approach.