Update tokio?#910
Conversation
Kixiron
added
S-waiting-on-review
jyn514
left a comment
jyn514
left a comment
There was a problem hiding this comment.
I'd like to make this wait in parallel before merging. Otherwise there's not much point in using async.
| ); | ||
| } | ||
|
|
||
| while let Some(result) = futures.next().await { |
There was a problem hiding this comment.
Same comment, this waits on each in serial. Can we wait in parallel instead? That was the whole point of switching to async in the first place.
There was a problem hiding this comment.
This also doesn't wait in serial since the containing collection is a FuturesUnordered. Calling .poll_next() (and transitively .next()) polls all contained futures until a ready one is found
There was a problem hiding this comment.
FuturesUnordered waits on all futures in itself concurrently.
There was a problem hiding this comment.
I'm still not quite following ... but @Nemo157 is I think one of the authors of futures so I'll take his word for it 😆
There was a problem hiding this comment.
For the record, Nemo explained it in more depth here: https://discordapp.com/channels/442252698964721669/541978667522195476/736708951332225226
jyn514
added
S-waiting-on-author
| ); | ||
| } | ||
|
|
||
| while let Some(result) = futures.next().await { |
There was a problem hiding this comment.
For the record, Nemo explained it in more depth here: https://discordapp.com/channels/442252698964721669/541978667522195476/736708951332225226
3 participants
With one runtime being used for S3 uploads via #909, it may work now?
Hopefully more successful than #799 and #758