feat: add public Refdb type #1228
Merged
weihanglo merged 3 commits intorust-lang:masterfrom Apr 20, 2026
Merged
Conversation
…, and delegate Repository::refdb_compress() to it
weihanglo
approved these changes
Apr 16, 2026
Member
There was a problem hiding this comment.
Thanks.
@bordumb let us know if you want to address the nit or not.
Contributor
Author
I've addressed the nit Please let me know what you think. Thanks! |
DanielEScherzer
approved these changes
Apr 20, 2026
weihanglo
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This is a followup PR to this one:
#1221
Specifically addressing the comment from @ehuss here:
#1221 (review)
2 additions:
Refdbtype rather than exposingrefdboperations solely as convenience methods on Repositoryset_refdb()as an example of how this new interface make extending it easier1 change:
RefdbtoRefdbMarkerto avoid confusion with the new publicRefdbtype inrefdb.rs; this is just a lifetime marker, not a user-facing type