Add support for remotes of branches #488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swsnr
changed the title
Member
|
Thanks! I wonder if it'd be better though here to return the |
Contributor
Author
|
I don’t know. For my purpose either is fine, but I don’t think I know Rust and Git so well as to make a general choice. I’d like to leave this to you, but I’m happy to update my pull request accordingly 🙂 |
Member
|
Ah ok, in that case yeah let's switch to returning |
Contributor
Author
|
@alexcrichton Thanks for the feedback; I'll do that soon :) |
Wrap git_branch_upstream_name and git_branch_upstream_remote which retrieve the configured upstream remote and branch, but do not attempt to resolve them, i.e. these functions don't fail if the configured upstream doesn't exist. Closes GH-469
Contributor
Author
|
@alexcrichton Done :) |
Member
|
👍 |
Contributor
Author
|
Many thanks for merging so quickly 🙏. And thanks for this great library! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap
git_branch_upstream_nameandgit_branch_upstream_remotewhich retrieve the configured upstream remote and branch, but do not attempt to resolve them, so unlikeBranch::upstreamthese functions don't fail if the branch has a configured upstream which doesn't exist. This way we can detect "gone" branches, i.e. branches whose upstream got deleted on the remote and was subsequently pruned bygit fetch.I don't know whether I put the functions in the correct place, and I'm not sure how to test these; I'm happy to amend this pull request if you would review it and give me directions.
Closes GH-469