clippy: fix unfulfilled_lint_expectations lint

[xtqqczze]

casting to a less strictly aligned pointer (u8) does not trigger the cast_ptr_alignment lint

warning: this lint expectation is unfulfilled
  --> src/control/group/neon.rs:43:14
   |
43 |     #[expect(clippy::cast_ptr_alignment)] // unaligned load
   |              ^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(unfulfilled_lint_expectations)]` on by default

    #[expect(clippy::cast_ptr_alignment)] // unaligned load
    pub(crate) unsafe fn load(ptr: *const Tag) -> Self {
        unsafe { Group(neon::vld1_u8(ptr.cast())) }
    }

[clarfonthey]

A little confused why these weren't breaking CI earlier. The intent was to only keep expects so we could remove them when they stopped triggering.

[xtqqczze]

I'm seeing these warnings locally when running:

cargo clippy --all --tests --features serde,rayon -- -D warnings`

Perhaps they haven’t shown up in CI because rustfmt_clippy runs on the i586-unknown-linux-gnu target, while I’m building on aarch64?

[clarfonthey]

Oh, yeah, huh. I guess that this is an issue when it comes to the SIMD code.

Not sure what the best solution is other than running clippy on those targets in CI too, hmm.

[xtqqczze]

Yeah CI needs a matrix strategy that runs clippy for every target, opened #691

[clarfonthey]

The main issue is that we test substantially more targets than would need clippy runs, since we want to verify performance and correctness. Honestly, the big issue is that clippy can't go through cfged code, but that's a story for another day.

I think we could definitely improve it by running clippy on more targets, however, to at least cover all the code.