Add #[must_use] to constructors#697
Merged
clarfonthey merged 2 commits intorust-lang:masterfrom Feb 28, 2026
Merged
Conversation
Contributor
|
Trailing spaces, apparently. Otherwise looks fine. |
This comment was marked as outdated.
This comment was marked as outdated.
Only the functions that match those in the standard library with `#[must_use]` annotations
xtqqczze
force-pushed
the
must-use-constructors
branch
from
2d0db92 to
a635266
Compare
xtqqczze
changed the title
#[must_use] to constructors
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
I would be comfortable adding all of those in this PR as well.
|
Contributor
Author
|
Pushed changes to add the annotation to similar methods in the standard library that have it, and those added in rust-lang/rust#153204. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also: rust-lang/rust#89692