Update the macros used for extern types #4759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Really what we are indicating with this macro invocation is that we need a type that can be specified behind indirection but never used directly, which is an extern type. Using an uninhabited enum gets us most of the way there and is about the best we can do for now.
tgross35
force-pushed
the
extern-macros
branch
from
03ff11f to
96c0862
Compare
Use the macro to replace repeated handwritten uninhabited enums. In order to keep the same traits, `extern_ty!` now implements `Clone` and `Copy` in addition to the existing `Debug`, which affects existing uses of `extern_ty!`. We don't need these traits since they can never be used on uninhabited types, but there is no harm in adding them for now and dropping later on.
tgross35
force-pushed
the
extern-macros
branch
from
96c0862 to
06b72ae
Compare
tgross35
added
the
stable-nominated
Collaborator
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 3, 2025
Really what we are indicating with this macro invocation is that we need a type that can be specified behind indirection but never used directly, which is an extern type. Using an uninhabited enum gets us most of the way there and is about the best we can do for now. (backport <rust-lang#4759>) (cherry picked from commit fe5ecb8)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 3, 2025
Use the macro to replace repeated handwritten uninhabited enums. In order to keep the same traits, `extern_ty!` now implements `Clone` and `Copy` in addition to the existing `Debug`, which affects existing uses of `extern_ty!`. We don't need these traits since they can never be used on uninhabited types, but there is no harm in adding them for now and dropping later on. (backport <rust-lang#4759>) (cherry picked from commit 147b462)
Merged
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 3, 2025
Really what we are indicating with this macro invocation is that we need a type that can be specified behind indirection but never used directly, which is an extern type. Using an uninhabited enum gets us most of the way there and is about the best we can do for now. (backport <rust-lang#4759>) (cherry picked from commit fe5ecb8)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 3, 2025
Use the macro to replace repeated handwritten uninhabited enums. In order to keep the same traits, `extern_ty!` now implements `Clone` and `Copy` in addition to the existing `Debug`, which affects existing uses of `extern_ty!`. We don't need these traits since they can never be used on uninhabited types, but there is no harm in adding them for now and dropping later on. (backport <rust-lang#4759>) (cherry picked from commit 147b462)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 4, 2025
Really what we are indicating with this macro invocation is that we need a type that can be specified behind indirection but never used directly, which is an extern type. Using an uninhabited enum gets us most of the way there and is about the best we can do for now. (backport <#4759>) (cherry picked from commit fe5ecb8)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 4, 2025
Use the macro to replace repeated handwritten uninhabited enums. In order to keep the same traits, `extern_ty!` now implements `Clone` and `Copy` in addition to the existing `Debug`, which affects existing uses of `extern_ty!`. We don't need these traits since they can never be used on uninhabited types, but there is no harm in adding them for now and dropping later on. (backport <#4759>) (cherry picked from commit 147b462)
tgross35
added
stable-applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details are in the commit messages