Skip to content

Conversation

@tgross35
Copy link
Contributor

See the commit messages for more details.

@rustbot label +stable-nominated

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Oct 22, 2025
The mentioned issues with `#include` no longer seem to happen, so start
testing these again.
@tgross35 tgross35 force-pushed the test-cleanup branch 8 times, most recently from 35895a5 to de14cd4 Compare October 22, 2025 23:09
@tgross35 tgross35 changed the title Unskip tests that now pass Linux: Unskip tests that now pass Oct 22, 2025
The reason these failed in the first place was unclear, but they now
pass.

Closes: rust-lang#1558
The distributed versions of glibc now have the `__ssp` field, so we can
add it here and start testing the type again. A field rename is needed
since loongarch calls `__uc_flags` by a different name.
The concerns about changing across versions was resolved a long time
ago. However, there is still a mismatch on PowerPC64, so a specific skip
is added for now.
`can_frame` and `canfd_frame` need this, but `canxl_frame` does not.
This was causing the struct to be incorrectly aligned.
Unskip a number of types and constants that were added in more recent
kernel versions but are now available in our CI setup.
Our musl tests now use more recent headers, so we can start testing a
number of types again.
Indicate which kernel version we are working with.
@tgross35 tgross35 marked this pull request as ready for review October 23, 2025 01:24
@tgross35 tgross35 added this pull request to the merge queue Oct 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 23, 2025
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 3, 2025
Unskip a number of types and constants that were added in more recent
kernel versions but are now available in our CI setup.

(backport <rust-lang#4760>)
(cherry picked from commit 969d956)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 3, 2025
Our musl tests now use more recent headers, so we can start testing a
number of types again.

(backport <rust-lang#4760>)
(cherry picked from commit 7238ba5)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 3, 2025
Indicate which kernel version we are working with.

(backport <rust-lang#4760>)
(cherry picked from commit cc3cee4)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 3, 2025
The mentioned issues with `#include` no longer seem to happen, so start
testing these again.

(backport <rust-lang#4760>)
(cherry picked from commit 758dc77)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 3, 2025
The reason these failed in the first place was unclear, but they now
pass.

Closes: rust-lang#1558

(backport <rust-lang#4760>)
(cherry picked from commit d4ffc25)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 3, 2025
The distributed versions of glibc now have the `__ssp` field, so we can
add it here and start testing the type again. A field rename is needed
since loongarch calls `__uc_flags` by a different name.

(backport <rust-lang#4760>)
(cherry picked from commit f9f21cf)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 3, 2025
The concerns about changing across versions was resolved a long time
ago. However, there is still a mismatch on PowerPC64, so a specific skip
is added for now.

(backport <rust-lang#4760>)
(cherry picked from commit dec14b0)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 3, 2025
`can_frame` and `canfd_frame` need this, but `canxl_frame` does not.
This was causing the struct to be incorrectly aligned.

(backport <rust-lang#4760>)
(cherry picked from commit 488022e)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 3, 2025
Unskip a number of types and constants that were added in more recent
kernel versions but are now available in our CI setup.

(backport <rust-lang#4760>)
(cherry picked from commit 969d956)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 3, 2025
Our musl tests now use more recent headers, so we can start testing a
number of types again.

(backport <rust-lang#4760>)
(cherry picked from commit 7238ba5)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 3, 2025
Indicate which kernel version we are working with.

(backport <rust-lang#4760>)
(cherry picked from commit cc3cee4)
@tgross35 tgross35 mentioned this pull request Nov 3, 2025
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 3, 2025
The mentioned issues with `#include` no longer seem to happen, so start
testing these again.

(backport <rust-lang#4760>)
(cherry picked from commit 758dc77)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 3, 2025
The reason these failed in the first place was unclear, but they now
pass.

Closes: rust-lang#1558

(backport <rust-lang#4760>)
(cherry picked from commit d4ffc25)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 3, 2025
The distributed versions of glibc now have the `__ssp` field, so we can
add it here and start testing the type again. A field rename is needed
since loongarch calls `__uc_flags` by a different name.

(backport <rust-lang#4760>)
(cherry picked from commit f9f21cf)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 3, 2025
The concerns about changing across versions was resolved a long time
ago. However, there is still a mismatch on PowerPC64, so a specific skip
is added for now.

(backport <rust-lang#4760>)
(cherry picked from commit dec14b0)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 3, 2025
`can_frame` and `canfd_frame` need this, but `canxl_frame` does not.
This was causing the struct to be incorrectly aligned.

(backport <rust-lang#4760>)
(cherry picked from commit 488022e)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 3, 2025
Unskip a number of types and constants that were added in more recent
kernel versions but are now available in our CI setup.

(backport <rust-lang#4760>)
(cherry picked from commit 969d956)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 3, 2025
Our musl tests now use more recent headers, so we can start testing a
number of types again.

(backport <rust-lang#4760>)
(cherry picked from commit 7238ba5)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 3, 2025
Indicate which kernel version we are working with.

(backport <rust-lang#4760>)
(cherry picked from commit cc3cee4)
github-merge-queue bot pushed a commit that referenced this pull request Nov 4, 2025
The mentioned issues with `#include` no longer seem to happen, so start
testing these again.

(backport <#4760>)
(cherry picked from commit 758dc77)
github-merge-queue bot pushed a commit that referenced this pull request Nov 4, 2025
The reason these failed in the first place was unclear, but they now
pass.

Closes: #1558

(backport <#4760>)
(cherry picked from commit d4ffc25)
github-merge-queue bot pushed a commit that referenced this pull request Nov 4, 2025
The distributed versions of glibc now have the `__ssp` field, so we can
add it here and start testing the type again. A field rename is needed
since loongarch calls `__uc_flags` by a different name.

(backport <#4760>)
(cherry picked from commit f9f21cf)
github-merge-queue bot pushed a commit that referenced this pull request Nov 4, 2025
The concerns about changing across versions was resolved a long time
ago. However, there is still a mismatch on PowerPC64, so a specific skip
is added for now.

(backport <#4760>)
(cherry picked from commit dec14b0)
github-merge-queue bot pushed a commit that referenced this pull request Nov 4, 2025
`can_frame` and `canfd_frame` need this, but `canxl_frame` does not.
This was causing the struct to be incorrectly aligned.

(backport <#4760>)
(cherry picked from commit 488022e)
github-merge-queue bot pushed a commit that referenced this pull request Nov 4, 2025
Unskip a number of types and constants that were added in more recent
kernel versions but are now available in our CI setup.

(backport <#4760>)
(cherry picked from commit 969d956)
github-merge-queue bot pushed a commit that referenced this pull request Nov 4, 2025
Our musl tests now use more recent headers, so we can start testing a
number of types again.

(backport <#4760>)
(cherry picked from commit 7238ba5)
github-merge-queue bot pushed a commit that referenced this pull request Nov 4, 2025
Indicate which kernel version we are working with.

(backport <#4760>)
(cherry picked from commit cc3cee4)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: CI-related items O-gnu O-linux O-unix O-x86 stable-applied This PR has been cherry-picked to libc's stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants