-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Linux: Unskip tests that now pass #4760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddb24df to
33282bb
Compare
The mentioned issues with `#include` no longer seem to happen, so start testing these again.
33282bb to
1ecef8b
Compare
35895a5 to
de14cd4
Compare
The reason these failed in the first place was unclear, but they now pass. Closes: rust-lang#1558
The distributed versions of glibc now have the `__ssp` field, so we can add it here and start testing the type again. A field rename is needed since loongarch calls `__uc_flags` by a different name.
The concerns about changing across versions was resolved a long time ago. However, there is still a mismatch on PowerPC64, so a specific skip is added for now.
`can_frame` and `canfd_frame` need this, but `canxl_frame` does not. This was causing the struct to be incorrectly aligned.
Unskip a number of types and constants that were added in more recent kernel versions but are now available in our CI setup.
Our musl tests now use more recent headers, so we can start testing a number of types again.
Indicate which kernel version we are working with.
de14cd4 to
27f9f7d
Compare
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 3, 2025
Unskip a number of types and constants that were added in more recent kernel versions but are now available in our CI setup. (backport <rust-lang#4760>) (cherry picked from commit 969d956)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 3, 2025
Our musl tests now use more recent headers, so we can start testing a number of types again. (backport <rust-lang#4760>) (cherry picked from commit 7238ba5)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 3, 2025
Indicate which kernel version we are working with. (backport <rust-lang#4760>) (cherry picked from commit cc3cee4)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 3, 2025
The mentioned issues with `#include` no longer seem to happen, so start testing these again. (backport <rust-lang#4760>) (cherry picked from commit 758dc77)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 3, 2025
The reason these failed in the first place was unclear, but they now pass. Closes: rust-lang#1558 (backport <rust-lang#4760>) (cherry picked from commit d4ffc25)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 3, 2025
The distributed versions of glibc now have the `__ssp` field, so we can add it here and start testing the type again. A field rename is needed since loongarch calls `__uc_flags` by a different name. (backport <rust-lang#4760>) (cherry picked from commit f9f21cf)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 3, 2025
The concerns about changing across versions was resolved a long time ago. However, there is still a mismatch on PowerPC64, so a specific skip is added for now. (backport <rust-lang#4760>) (cherry picked from commit dec14b0)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 3, 2025
`can_frame` and `canfd_frame` need this, but `canxl_frame` does not. This was causing the struct to be incorrectly aligned. (backport <rust-lang#4760>) (cherry picked from commit 488022e)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 3, 2025
Unskip a number of types and constants that were added in more recent kernel versions but are now available in our CI setup. (backport <rust-lang#4760>) (cherry picked from commit 969d956)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 3, 2025
Our musl tests now use more recent headers, so we can start testing a number of types again. (backport <rust-lang#4760>) (cherry picked from commit 7238ba5)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 3, 2025
Indicate which kernel version we are working with. (backport <rust-lang#4760>) (cherry picked from commit cc3cee4)
Merged
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 3, 2025
The mentioned issues with `#include` no longer seem to happen, so start testing these again. (backport <rust-lang#4760>) (cherry picked from commit 758dc77)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 3, 2025
The reason these failed in the first place was unclear, but they now pass. Closes: rust-lang#1558 (backport <rust-lang#4760>) (cherry picked from commit d4ffc25)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 3, 2025
The distributed versions of glibc now have the `__ssp` field, so we can add it here and start testing the type again. A field rename is needed since loongarch calls `__uc_flags` by a different name. (backport <rust-lang#4760>) (cherry picked from commit f9f21cf)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 3, 2025
The concerns about changing across versions was resolved a long time ago. However, there is still a mismatch on PowerPC64, so a specific skip is added for now. (backport <rust-lang#4760>) (cherry picked from commit dec14b0)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 3, 2025
`can_frame` and `canfd_frame` need this, but `canxl_frame` does not. This was causing the struct to be incorrectly aligned. (backport <rust-lang#4760>) (cherry picked from commit 488022e)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 3, 2025
Unskip a number of types and constants that were added in more recent kernel versions but are now available in our CI setup. (backport <rust-lang#4760>) (cherry picked from commit 969d956)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 3, 2025
Our musl tests now use more recent headers, so we can start testing a number of types again. (backport <rust-lang#4760>) (cherry picked from commit 7238ba5)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 3, 2025
Indicate which kernel version we are working with. (backport <rust-lang#4760>) (cherry picked from commit cc3cee4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit messages for more details.
@rustbot label +stable-nominated