[0.2] ci: Run semver checks even on non-host targets #4818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
force-pushed
the
backport-more-semver
branch
4 times, most recently
from
a932a24 to
8a6762f
Compare
Collaborator
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
tgross35
force-pushed
the
backport-more-semver
branch
2 times, most recently
from
81d8a0f to
0414a94
Compare
tgross35
force-pushed
the
backport-more-semver
branch
from
0414a94 to
7a43e56
Compare
Collaborator
|
This PR was rebased onto a different libc-0.2 commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
tgross35
force-pushed
the
backport-more-semver
branch
from
7a43e56 to
cfdf7c6
Compare
Add a version of semver checks that run on non-host targets by building rustdoc JSON output and passing that to `cargo-semver-checks`. Unfortunately this doesn't have a way to suppress false positives, so we need to leave the checks as optional rather than enforced for now (i.e. the exit code isn't checked).
tgross35
force-pushed
the
backport-more-semver
branch
from
cfdf7c6 to
cf9b094
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a version of semver checks that run on non-host targets by building
rustdoc JSON output and passing that to
cargo-semver-checks.Unfortunately this doesn't have a way to suppress false positives, so we
need to leave the checks as optional rather than enforced for now (i.e.
the exit code isn't checked).
Link: obi1kenobi/cargo-semver-checks#827