cleanup: Mark private padding fields as Padding #4862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
O-android
O-arm
O-dragonfly
O-gnu
O-linux
O-linux-like
O-macos
O-mips
O-musl
O-powerpc
O-redox
O-riscv
O-solarish
O-sparc
O-unix
O-x86
S-waiting-on-review
stable-nominated
3v1n0
force-pushed
the
fix-private-paddings
branch
2 times, most recently
from
1178dda to
367aa5a
Compare
3v1n0
commented
Dec 3, 2025
3v1n0
force-pushed
the
fix-private-paddings
branch
2 times, most recently
from
c088a8f to
dc20464
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
tgross35
reviewed
Dec 3, 2025
Contributor
tgross35
left a comment
tgross35
left a comment
There was a problem hiding this comment.
Just one request about uninit, the rest LGTM!
It allows to uninitialize padding areas in const contextes.
We have more private fields that are padding areas that are currently not marked as Padding, which is causing the generated Hash and PartialEq implementations to take care of them wrongly. Fix them
As previous commit, but tackle the *padding* fields
Some were already done, more were missing
3v1n0
force-pushed
the
fix-private-paddings
branch
from
dc20464 to
29b49bb
Compare
tgross35
approved these changes
Dec 3, 2025
Contributor
tgross35
left a comment
tgross35
left a comment
There was a problem hiding this comment.
Looks awesome, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have more private fields that are padding areas that are currently
not marked as Padding, which is causing the generated Hash
and PartialEq implementations to take care of them wrongly.
Fix them
This is a pre-requisite and API-compatible version of
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI
@rustbot label +stable-nominated