Remove nonexistent clocks on WASI #4880
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were added way back when in rust-lang#2499 and while they may have existed in a historical version of wasi-libc they most certainly do not exist in the current wasi-libc. Any usage of them is already-breaking, so this deletes these items.
Member
Author
|
This is something I'd ideally like to backport to the 0.2 version as well, although naturally it's a strictly-speaking breaking change. Technically historical changes like ca20d7d were also breaking in a minor fashion too, but this in theory could have higher impact because it's a more C-like constant rather than something libc-specific. Basically I don't know what the fallout of this would be. Extrapolating the highest risk is a crate that uses these constants in platform-specific code, including WASI, but the code is dead at runtime so no one noticed that it wouldn't work if it were executed. I'm not sure how prevalent such a situation is, however. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were added way back when in #2499 and while they may have existed in a historical version of wasi-libc they most certainly do not exist in the current wasi-libc. Any usage of them is already-breaking, so this deletes these items.