Skip to content

Conversation

@Gelbpunkt
Copy link
Contributor

Description

This fixes the remaining issues with the s390x musl definitions. libc-test passes fine after these changes.

Sources

https://github.com/bminor/musl/blob/master/arch/s390x/bits/signal.h#L5-L6

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot label +stable-nominated

@rustbot rustbot added O-linux O-musl O-unix S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Dec 16, 2025
Musl does not provide these.

Signed-off-by: Jens Reidel <adrian@travitia.xyz>
These have had the values 10240 and 4096 respectively since the introduction
of the s390x port in musl back in 2016.

Signed-off-by: Jens Reidel <adrian@travitia.xyz>
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tgross35 tgross35 changed the title Some tiny s390x musl fixes musl: s390x: Fix the values of SIGSTKSZ MINSIGSTKSZ Dec 17, 2025
@tgross35 tgross35 added this pull request to the merge queue Dec 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 17, 2025
@tgross35 tgross35 added this pull request to the merge queue Dec 17, 2025
Merged via the queue into rust-lang:main with commit cde9e8a Dec 17, 2025
51 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Dec 28, 2025
Musl does not provide these.

Signed-off-by: Jens Reidel <adrian@travitia.xyz>

(backport <rust-lang#4884>)
(cherry picked from commit 3d372c6)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Dec 28, 2025
These have had the values 10240 and 4096 respectively since the introduction
of the s390x port in musl back in 2016.

Signed-off-by: Jens Reidel <adrian@travitia.xyz>

(backport <rust-lang#4884>)
(cherry picked from commit cde9e8a)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Jan 3, 2026
Musl does not provide these.

Signed-off-by: Jens Reidel <adrian@travitia.xyz>

(backport <rust-lang#4884>)
(cherry picked from commit 3d372c6)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Jan 3, 2026
These have had the values 10240 and 4096 respectively since the introduction
of the s390x port in musl back in 2016.

Signed-off-by: Jens Reidel <adrian@travitia.xyz>

(backport <rust-lang#4884>)
(cherry picked from commit cde9e8a)
@tgross35 tgross35 mentioned this pull request Jan 3, 2026
github-merge-queue bot pushed a commit that referenced this pull request Jan 3, 2026
Musl does not provide these.

Signed-off-by: Jens Reidel <adrian@travitia.xyz>

(backport <#4884>)
(cherry picked from commit 3d372c6)
github-merge-queue bot pushed a commit that referenced this pull request Jan 3, 2026
These have had the values 10240 and 4096 respectively since the introduction
of the s390x port in musl back in 2016.

Signed-off-by: Jens Reidel <adrian@travitia.xyz>

(backport <#4884>)
(cherry picked from commit cde9e8a)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Jan 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-linux O-musl O-unix stable-applied This PR has been cherry-picked to libc's stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants