-
Notifications
You must be signed in to change notification settings - Fork 1.2k
musl: s390x: Fix the values of SIGSTKSZ MINSIGSTKSZ
#4884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Musl does not provide these. Signed-off-by: Jens Reidel <adrian@travitia.xyz>
These have had the values 10240 and 4096 respectively since the introduction of the s390x port in musl back in 2016. Signed-off-by: Jens Reidel <adrian@travitia.xyz>
90d7412 to
a9675b5
Compare
tgross35
approved these changes
Dec 17, 2025
Contributor
tgross35
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
SIGSTKSZ MINSIGSTKSZ
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Dec 28, 2025
Musl does not provide these. Signed-off-by: Jens Reidel <adrian@travitia.xyz> (backport <rust-lang#4884>) (cherry picked from commit 3d372c6)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Dec 28, 2025
These have had the values 10240 and 4096 respectively since the introduction of the s390x port in musl back in 2016. Signed-off-by: Jens Reidel <adrian@travitia.xyz> (backport <rust-lang#4884>) (cherry picked from commit cde9e8a)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Jan 3, 2026
Musl does not provide these. Signed-off-by: Jens Reidel <adrian@travitia.xyz> (backport <rust-lang#4884>) (cherry picked from commit 3d372c6)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Jan 3, 2026
These have had the values 10240 and 4096 respectively since the introduction of the s390x port in musl back in 2016. Signed-off-by: Jens Reidel <adrian@travitia.xyz> (backport <rust-lang#4884>) (cherry picked from commit cde9e8a)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the remaining issues with the s390x musl definitions. libc-test passes fine after these changes.
Sources
https://github.com/bminor/musl/blob/master/arch/s390x/bits/signal.h#L5-L6
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI
@rustbot label +stable-nominated