Skip to content

netbsd: restore getmntinfo link symbol.#5251

Open
fraggerfox wants to merge 1 commit into
rust-lang:mainfrom
fraggerfox:netbsd-restore-getmntinfo-link-symbol
Open

netbsd: restore getmntinfo link symbol.#5251
fraggerfox wants to merge 1 commit into
rust-lang:mainfrom
fraggerfox:netbsd-restore-getmntinfo-link-symbol

Conversation

@fraggerfox

@fraggerfox fraggerfox commented Jul 4, 2026

Copy link
Copy Markdown

Description

Restore the link symbol for getmntinfo accidentally reverted in 1816f6061

Sources

Checklist

  • Relevant tests in libc-test/semver have been updated
    • Not applicable.
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
    • Not applicable.
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot label +stable-nominated

@fraggerfox fraggerfox force-pushed the netbsd-restore-getmntinfo-link-symbol branch from fbb250e to 9ad91c6 Compare July 4, 2026 16:58
@fraggerfox fraggerfox marked this pull request as ready for review July 4, 2026 17:08
@rustbot

rustbot commented Jul 4, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in a NetBSD-like module

cc @semarie

@rustbot rustbot added S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Jul 4, 2026

@tgross35 tgross35 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait on @0323pin to ack but this LGTM, thank you and sorry for the confusion.

Were you able to test whether this fixes bottom?

View changes since this review

@fraggerfox

Copy link
Copy Markdown
Author

Were you able to test whether this fixes bottom?

bottom builds and runs, but the Disks panel is empty, I will need to investigate why it is failing to fetch the data.

@fraggerfox

Copy link
Copy Markdown
Author

Were you able to test whether this fixes bottom?

bottom builds and runs, but the Disks panel is empty, I will need to investigate why it is failing to fetch the data.

image

@tgross35 : They are showing up correctly. In my previous attempt I was in the wrong branch and compiled the wrong code.

@0323pin

0323pin commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

I'll wait on @0323pin to ack but this LGTM, thank you and sorry for the confusion.

Were you able to test whether this fixes bottom?

View changes since this review

I think I'm fine with this.
@fraggerfox was your test on 10 or, 11?

@fraggerfox

Copy link
Copy Markdown
Author

I'll wait on @0323pin to ack but this LGTM, thank you and sorry for the confusion.
Were you able to test whether this fixes bottom?
View changes since this review

I think I'm fine with this. @fraggerfox was your test on 10 or, 11?

This was on 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants