Also grep -v out .cargo_vcs_info.json in cargo-zng
#217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to `Cargo.toml.orig`. This also refactors the command to use fixed string (`-F`) and match whole lines (`-x`), to eliminate the `^` and `$` anchors and `\` escapes from the pattern. See rust-lang#214.
Byron
approved these changes
Sep 7, 2024
Member
Byron
left a comment
Byron
left a comment
There was a problem hiding this comment.
Thanks a lot, much appreciated!
I particularly like how the grep line has been improved, I had no idea it could do that!.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #214
In the
cargo-zngscript, this has thegrep -vcommand that filters outCargo.toml.origalso filiter out.cargo_vcs_info.json.It also refactors the command to use fixed string (
-F) and match whole lines (-x), to eliminate the^and$anchors and\escapes from the pattern(s).This is working for
./cargo-zngand./cargo-zng buildon Ubuntu 24.04 LTS, macOS 14.6, and Windows 10 in Git Bash.