Search highlights don’t disappear from URL when clicked

[steffahn]

In search results, you get URLs such as https://doc.rust-lang.org/book/ch04-01-what-is-ownership.html?highlight=ownership#what-is-ownership that highlight the search results. It’s possible to press ESC to remove the highlights and update the URL accordingly. There’s also the option to click on any of the hightlights, which makes them invisible but does not update the URL.

I would appreciate if that changed, so that the URL get’s updated (i.e. the ?highlight=foo part removed) by clicking on a highlight, too. I only very recently learned about the ESC-key way in the first place and always had to edit the URL manually before, in order to share a link.

[schungx]

I only very recently learned about the ESC-key way in the first place and always had to edit the URL manually before, in order to share a link.

+1 to this. I didn't know about the Esc trick, so I always have to manually edit the URL in order to copy the link to share to somebody. This has been a constant annoyance to me until now.

However, I suppose since we already have Esc to remove the search parameters, it is not critical for clicking on a highlight to remove them, because AFTER clicking on a highlight (when all highlights are gone), you can STILL press Esc to remove the search parameters from the URL.

[steffahn]

However, I suppose since we already have Esc to remove the search parameters, it is not critical for clicking on a highlight to remove them, because AFTER clicking on a highlight (when all highlights are gone), you can STILL press Esc to remove the search parameters from the URL.

As you experienced yourself, it’s very hard to find out about the ESC-“trick”. Furthermore it doesn’t work at all on mobile (for lack of a keyboard). I, too, noticed myself that ESC still works after the highlights are visually gone, and for me (and you) personally, while on a computer, knowing about ESC solves all problems w.r.t. sharing links, but all this doesn’t really make the issue any less “critical” IMO.

[ehuss]

This should be a very easy fix if someone wants to post a PR, I'll review it.

[tonywu6]

@rustbot claim