Skip to content

Conversation

@funkill
Copy link
Contributor

@funkill funkill commented Feb 16, 2016

No description provided.

@azerupi
Copy link
Contributor

azerupi commented Feb 16, 2016

What does this change for you? I tried to apply this in browser (firefox) and it doesn't seem to change much for me.

@funkill
Copy link
Contributor Author

funkill commented Feb 16, 2016

it's not critical and changes sees only in very big zoom: hovered area has rectangle figure without rounded angles, but theme selector's angles is rounded
in picture: up - in master, down - in this commit
theme selector

@azerupi
Copy link
Contributor

azerupi commented Feb 16, 2016

Ah yes, I wasn't zoomed in enough to see it clearly. It's good, I will
merge when I come home. Thanks! :)
On Feb 16, 2016 9:40 AM, "funkill" notifications@github.com wrote:

it's not critical and changes sees only in very big zoom: hovered area has
rectangle figure without rounded angles, but theme selector's angles is
rounded
in picture: up - in master, down - in this commit
[image: theme selector]
https://cloud.githubusercontent.com/assets/4323287/13071014/b02be040-d4a1-11e5-928e-a5d3da2c710f.png


Reply to this email directly or view it on GitHub
https://github.com/azerupi/mdBook/pull/108#issuecomment-184576943.

azerupi added a commit that referenced this pull request Feb 16, 2016
add rounding for first and last items in theme selector
@azerupi azerupi merged commit fc86b96 into rust-lang:master Feb 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants