Filter mark tags from sidebar heading nav #2899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The search marker is getting copied into the sidebar, but it cannot be dismissed.
ehuss
force-pushed
the
filtered-headings
branch
from
8ec8365 to
3b07ada
Compare
This makes sure that the sidebar headings don't have the `<mark>` tag. When these are created, the Marker is unable to remove them from the sidebar (and we don't want them there in the first place). I suspect we'll want more filtering in the future, but I'm not sure exactly what to filter. Alternatively, it could have an allow list of tags, and filter all others out.
ehuss
force-pushed
the
filtered-headings
branch
from
3b07ada to
1881351
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that the sidebar headings don't have the
<mark>tag. When these are created, the Marker is unable to remove them from the sidebar (and we don't want them there in the first place).I suspect we'll want more filtering in the future, but I'm not sure exactly what to filter. Alternatively, it could have an allow list of tags, and filter all others out.