Skip to content

Add docs for mdBook specific include feature #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2018
Merged

Add docs for mdBook specific include feature #593

merged 2 commits into from
Jan 31, 2018

Conversation

@boxdot
Copy link
Contributor

@boxdot boxdot commented Jan 27, 2018

Also:

  • Fix bug in take_lines taking end-many lines instead of end-start many.
  • Handle special case include:number as including a single line.
  • Start counting lines at 1 and not 0.

@boxdot
Add docs for mdBook specific include feature.
615a79d 
Also:
* Fix bug in take_lines taking `end`-many lines instead of
  `end-start` many.
* Handle special case `include:number` as including a single line.
* Start counting lines at 1 and not 0.
@Michael-F-Bryan
Copy link
Contributor

Michael-F-Bryan commented Jan 28, 2018

Should we merge this new chapter of the user guide with the Rust code specific features page? I feel like they both fall under the same umbrella because they're mdbook-specific helpers for including things in a document.

@boxdot
Copy link
Contributor Author

boxdot commented Jan 28, 2018

Should we merge this new chapter of the user guide with the Rust code specific features page?

Good idea. I merged them into a single page.

@Michael-F-Bryan Michael-F-Bryan merged commit bf9f58e into rust-lang:master Jan 31, 2018
Ruin0x11 pushed a commit to Ruin0x11/mdBook that referenced this pull request Aug 30, 2020
@boxdot @Michael-F-Bryan
Add docs for mdBook specific include feature (rust-lang#593)
b4ee9e4 
* Add docs for mdBook specific include feature.

Also:
* Fix bug in take_lines taking `end`-many lines instead of
  `end-start` many.
* Handle special case `include:number` as including a single line.
* Start counting lines at 1 and not 0.

* Merge mdBook and rust specific features into one chapter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@boxdot @Michael-F-Bryan