emit stashed diagnostics before flushing delayed errors #4702
+23
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thank you for contributing to Miri! A reviewer will take a look at your PR, typically within a week or two. |
RalfJung
changed the title
RalfJung
force-pushed
the
stashed-diag
branch
from
de314d6 to
7b3cfac
Compare
RalfJung
force-pushed
the
stashed-diag
branch
from
7b3cfac to
e386e57
Compare
RalfJung
force-pushed
the
stashed-diag
branch
from
e386e57 to
52f060a
Compare
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 18, 2025
flush_delayed: add note about stashed diagnostics r? `@nnethercote` Is `emit_stashed_diagnostics` the right advice to give? The other option seems to be to call `finish_diagnostics`. That's what I ended up doing (for now) in rust-lang/miri#4702 because it best matches what happens during normal compilation.
rust-timer
added a commit
to rust-lang/rust
that referenced
this pull request
Nov 18, 2025
Rollup merge of #149020 - RalfJung:flush_delayed, r=nnethercote flush_delayed: add note about stashed diagnostics r? `@nnethercote` Is `emit_stashed_diagnostics` the right advice to give? The other option seems to be to call `finish_diagnostics`. That's what I ended up doing (for now) in rust-lang/miri#4702 because it best matches what happens during normal compilation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4698