Skip to content

Refactor epoll tests to use errno_result and improve notification checks#4772

Merged
RalfJung merged 2 commits intorust-lang:masterfrom
hulxv:refactor/simplify-libc-tests/libc-epoll-blocking
Jan 18, 2026
Merged

Refactor epoll tests to use errno_result and improve notification checks#4772
RalfJung merged 2 commits intorust-lang:masterfrom
hulxv:refactor/simplify-libc-tests/libc-epoll-blocking

Conversation

@hulxv
Copy link
Copy Markdown
Contributor

@hulxv hulxv commented Dec 17, 2025

Related to #4725

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Dec 17, 2025

Thank you for contributing to Miri! A reviewer will take a look at your PR, typically within a week or two.
Please remember to not force-push to the PR branch except when you need to rebase due to a conflict or when the reviewer asks you for it.

@rustbot rustbot added the S-waiting-on-review Status: Waiting for a review to complete label Dec 17, 2025
@RalfJung
Copy link
Copy Markdown
Member

As discussed in the other PRs, marking as "waiting for author" until the first PRs landed, to avoid repeating the same review comments. We will get them all landed if you stick around, we should just take things one after the other. :)
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: Waiting for the PR author to address review comments and removed S-waiting-on-review Status: Waiting for a review to complete labels Dec 22, 2025
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Dec 22, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@hulxv hulxv force-pushed the refactor/simplify-libc-tests/libc-epoll-blocking branch from 82af329 to e22dd6f Compare January 8, 2026 00:08
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jan 8, 2026

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@hulxv
Copy link
Copy Markdown
Contributor Author

hulxv commented Jan 12, 2026

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Waiting for a review to complete and removed S-waiting-on-author Status: Waiting for the PR author to address review comments labels Jan 12, 2026
@RalfJung
Copy link
Copy Markdown
Member

Thanks! This is a good first step for these tests. However, they are not done yet: the check_epoll_wait function in "no-blocking.rs" should be removed and replaced by the one from utils; there are many calls to write_all that should use one of the fancier helpers; there are a bunch more opportunities to use epoll_ctl_add. This can be done in a follow-up PR. :)

@RalfJung RalfJung enabled auto-merge January 18, 2026 14:34
@RalfJung RalfJung added this pull request to the merge queue Jan 18, 2026
Merged via the queue into rust-lang:master with commit c058229 Jan 18, 2026
13 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Waiting for a review to complete label Jan 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants