Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions src/vec/vec-alloc.md
Original file line number Diff line number Diff line change
Expand Up @@ -170,20 +170,17 @@ use std::alloc::{self, Layout};
impl<T> Vec<T> {
fn grow(&mut self) {
let (new_cap, new_layout) = if self.cap == 0 {
(1, Layout::array::<T>(1).unwrap())
(1, Layout::array::<T>(1))
} else {
// This can't overflow since self.cap <= isize::MAX.
let new_cap = 2 * self.cap;

// `Layout::array` checks that the number of bytes is <= usize::MAX,
// but this is redundant since old_layout.size() <= isize::MAX,
// so the `unwrap` should never fail.
let new_layout = Layout::array::<T>(new_cap).unwrap();
(new_cap, new_layout)
(new_cap, Layout::array::<T>(new_cap))
};

// Ensure that the new allocation doesn't exceed `isize::MAX` bytes.
assert!(new_layout.size() <= isize::MAX as usize, "Allocation too large");
// `Layout::array` checks that the number of bytes allocated is
// in 1..=isize::MAX and will error otherwise. An allocation of
// 0 bytes isn't possible thanks to the above condition.
let new_layout = new_layout.expect("Allocation too large");

let new_ptr = if self.cap == 0 {
unsafe { alloc::alloc(new_layout) }
Expand Down
20 changes: 7 additions & 13 deletions src/vec/vec-final.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,23 +33,17 @@ impl<T> RawVec<T> {
assert!(mem::size_of::<T>() != 0, "capacity overflow");

let (new_cap, new_layout) = if self.cap == 0 {
(1, Layout::array::<T>(1).unwrap())
(1, Layout::array::<T>(1))
} else {
// This can't overflow because we ensure self.cap <= isize::MAX.
// This can't overflow since self.cap <= isize::MAX.
let new_cap = 2 * self.cap;

// `Layout::array` checks that the number of bytes is <= usize::MAX,
// but this is redundant since old_layout.size() <= isize::MAX,
// so the `unwrap` should never fail.
let new_layout = Layout::array::<T>(new_cap).unwrap();
(new_cap, new_layout)
(new_cap, Layout::array::<T>(new_cap))
};

// Ensure that the new allocation doesn't exceed `isize::MAX` bytes.
assert!(
new_layout.size() <= isize::MAX as usize,
"Allocation too large"
);
// `Layout::array` checks that the number of bytes allocated is
// in 1..=isize::MAX and will error otherwise. An allocation of
// 0 bytes isn't possible thanks to the above condition.
let new_layout = new_layout.expect("Allocation too large");

let new_ptr = if self.cap == 0 {
unsafe { alloc::alloc(new_layout) }
Expand Down