Update diagnostics to use the attribute template #1890
+192
−181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This is intended to be a general intro for all of the lint check attributes, so name them here.
This adds the corresponding rules, and reworks a little to be explicit about the syntax.
The style we have generally settled on is to *not* surround the name of the attribute with `#[]`.
I'd like to avoid "intro" rules that are the core definition of a thing.
This moves the note so that it isn't dangling at the bottom of the section. I generally would like to avoid these, since it isn't clear if the note is tied to the previous rule, or the entire section. This seems to fit with this rule better, anyways.
traviscross
force-pushed
the
diagnostics
branch
from
431164d to
c06733c
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@traviscross I think when we were talking you said that you had some edits here but I don't think they got pushed up. Were they complete? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New rules:
attributes.diagnostics.lint.introattributes.diagnostics.lint.syntaxattributes.diagnostics.lint.allowed-positionsattributes.diagnostics.lint.duplicatesRenamed rules:
attributes.diagnostics.expect.introis nowattributes.diagnostics.expect.behavior