Actually move out of Box in moving-out-of-Box test#2204
Actually move out of Box in moving-out-of-Box test#2204ehuss merged 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
src/expressions/operator-expr.md
Outdated
| assert_eq!(*y, 11); | ||
| let z = Box::new(NoCopy); | ||
| let _: NoCopy = *z; | ||
| let _z: NoCopy = *z; |
There was a problem hiding this comment.
drop::<NoCopy>(*z) or { *z } would also get the job done here. Maybe the drop would be the most explicit? Using a pattern binding is a bit more subtle; I expect it may not be obvious if you're not deeply in the weeds already that _z differs from _.
src/expressions/operator-expr.md
Outdated
| let z = Box::new(NoCopy); | ||
| let _: NoCopy = *z; | ||
| let _z: NoCopy = *z; |
There was a problem hiding this comment.
I think to maintain consistency with the rest of the example above, it's fine to just assign to a local.
Since we have kind of run out of letters, and to avoid any confusion around _ prefixes, how about just using different variable names here? Such as a and b or whatever.
There was a problem hiding this comment.
Using a, b, etc. sounds fine to me; I've done that (after slightly misinterpreting and first renaming _z to a ^^). I broke the pattern intentionally since that assignment is part of the example for Box (I figured each reference/pointer would get one letter), but I agree about avoiding _ prefixes. In any case, I don't have a strong preference.
dianne
force-pushed
the
fix-box-deref-example
branch
2 times, most recently
from
cf23bba to
93bd844
Compare
dianne
force-pushed
the
fix-box-deref-example
branch
from
93bd844 to
95aaeee
Compare
rustbot
removed
the
S-waiting-on-review
3 participants
I looked at #2075 again after it merged and noticed a test I wrote there is wrong; oops!
let _ = $place;doesn't actually perform a move; a place-to-value coercion is needed.