parens are not optional in guard chains that have || operators#2224
Merged
Conversation
rustbot
added
the
S-waiting-on-review
ehuss
reviewed
Apr 28, 2026
|
|
||
| r[expr.if.chains.or] | ||
| If any condition operand is a `let` pattern, then none of the condition operands can be a `||` [lazy boolean operator expression][expr.bool-logic] due to ambiguity and precedence with the `let` scrutinee. If a `||` expression is needed, then parentheses can be used. For example: | ||
| If any condition operand is a `let` pattern, then none of the condition operands can be a `||` [lazy boolean operator expression][expr.bool-logic] due to ambiguity and precedence with the `let` scrutinee. If a `||` expression is needed, then parentheses must be used. For example: |
Contributor
There was a problem hiding this comment.
I don't think it is correct to use "must" here. This is saying that this is an option for how to work around the limitation. For example, you could sometimes use curly braces, or lift parts out to a variable, or don't use chains.
I think the correct change would be to move this statement out to an example block like the other one, since it isn't a language rule.
Also - Make an example follow convention (mark with `[!EXAMPLE]`) - Change formatting to place comment closer to its code
This is to match the original wording and to match the wording in expr.match.guard.chains.or. Parentheses are not necessarily the only way to work around this limitation. For example, you could sometimes use curly braces, or lift parts out to a variable, or don't use chains.
ehuss
approved these changes
May 26, 2026
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.