gitignore linkcheck#2252
Merged
ehuss merged 1 commit intorust-lang:masterfrom May 4, 2026
Merged
Conversation
Ignore linkcheck.sh, which is downloaded by the linkcheck test.
rustbot
added
the
S-waiting-on-review
DanielEScherzer
approved these changes
May 4, 2026
ehuss
approved these changes
May 4, 2026
Contributor
There was a problem hiding this comment.
Thanks! I'm going to go ahead and approve for now. But I feel like there could be a better longer-term solution that doesn't leave the file lying around. Perhaps the xtask should just automatically delete it?
Unfortunately deleting it would interrupt a workflow of doing iterative linkcheck testing, which can be much faster. Maybe that could somehow be natively handled in the xtask, and store the script somewhere out of the way? I just don't know where that would be.
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore linkcheck.sh, which is downloaded by the linkcheck test.