multi-token mapping for runnables.rs (#10070)

[spookyvision]

implement #10070 in runnables

[lnicola]

r? @Veykril

EDIT: sorry, never mind.

[jonas-schievink]

Looks good! I haven't figured out a way to test this yet, since "Peek Related Tests" does not work on first and second in the following code:

fn first() {}
fn second() {}

macro_rules! m {
    ($test:ident -> $first:ident, $second:ident) => {
        #[test]
        fn $test() {
            $first();
        }

        mod module {
            #[test]
            fn $test() {
                crate::$second();
            }
        }
    };
}

m!(abc -> first, second);

[spookyvision]

Looks good! I haven't figured out a way to test this yet, since "Peek Related Tests" does not work on first and second in the following code:

// ...

Does it depend on some other aspect of this ticket or another missing feature?

[jonas-schievink]

Does it depend on some other aspect of this ticket or another missing feature?

I don't think it's part of #10070, but I'm not really sure what exactly the problem is either

[jonas-schievink]

bors d+

Looks like CI will do the remaining review, feel free to r+ once that passes

[bors]

✌️ spookyvision can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

[lnicola]

Squashing should fix the CI error.

[spookyvision]

bors r+

[lnicola]

But you didn't squash..

[spookyvision]

But you didn't squash..

sorry - how should I fix this now?

[lnicola]

bors r-

[bors]

Canceled.

[lnicola]

Untested:

$ git rebase -i @~4
# edit the file to put `f` or `fixup` on the last three commits (if vim starts, you'll need to press `i` to insert, then quit with `ESC` and  `:wq`
$ git log # check that there's only one commit
$ git show # check that the commit looks correct
$ git push --force-with-lease

[lnicola]

Umm, that didn't come out right.

[lnicola]

Ah, sorry, that should have been fixup, not pick.

[spookyvision]

Untested:

# ...

sorry, I wasn't clear in my phrasing, I wanted to ask how to undo the bors action 😆 - that seems resolved after your r-?

(rebase help is also always appreciated, but I think I nailed it now, after making it much worse temporarily)

[jonas-schievink]

bors r+

[lnicola]

bors r-

I already filed and r+ed #10188.

sorry, I wasn't clear in my phrasing, I wanted to ask how to undo the bors action laughing - that seems resolved after your r-?

Oh, sorry.

[bors]

Canceled.