assists: turn while into loop #10257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agluszak
commented
Sep 16, 2021
agluszak
force-pushed
the
10214-turn-while-into-loop
branch
from
6b36b5a to
72306e1
Compare
Member
|
Regarding naming, I'm not sure either we probably should revisit the assist names at some point to make some more consistent. So using convert as a name is fine for now. Also once you are done you'll want to run |
agluszak
force-pushed
the
10214-turn-while-into-loop
branch
from
72306e1 to
b8299f8
Compare
Veykril
reviewed
Sep 16, 2021
Veykril
reviewed
Sep 16, 2021
agluszak
force-pushed
the
10214-turn-while-into-loop
branch
from
b8299f8 to
0ef1b4e
Compare
agluszak
force-pushed
the
10214-turn-while-into-loop
branch
from
0ef1b4e to
11a56f8
Compare
Contributor
Author
|
Oops, I should have made another commit instead of a force push, I hope you don't mind |
Member
|
No problem force pushes are fine here since the commit wasnt that big anyways |
Member
|
changelog feat (first contribution) add "Convert |
Contributor
Member
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements an assist to turn a
whileloop into alooploop, as requested in #10214.I'm not sure sure what the guidelines are regarding naming assists convert_x_to_y vs replace_x_with_y.
This is my first commit to rust-analyzer :D Thank you @matklad for your awesome Explaining rust-analyzer series <3
Closes #10214