feat: Add type hint for keyword expression hovers #11369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danii
changed the title
Veykril
changed the title
Veykril
reviewed
Jan 31, 2022
Cleaned up the code for keyword expression hovers. Added a check to hide units `()` in keyword expression hovers.
Contributor
Author
|
Sorry for the small delay. I was also debating on whether or not units should really be hidden from the hover/tooltip/whatever but I noticed there is precedence. Hopefully this all looks good. |
Contributor
Author
|
Also it doesn't look like |
Member
That's because it has no documentation in the standard library yet(given its an unstable feature) |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the return type of keywords to tool-tips where it makes sense. This applies to:
if,else,match,loop,unsafeandawait. Thanks to @Veykril for sharing the idea of putting return type highlighting on other keywords!Closes #11359