fix(completion): recursive super:: completion in crate root
#12447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feniljain
force-pushed
the
fix_completions
branch
from
bcea7cd to
7fa9ef0
Compare
feniljain
force-pushed
the
fix_completions
branch
from
7fa9ef0 to
10c66f2
Compare
feniljain
changed the title
super:: completion in crate root
Veykril
reviewed
Jun 3, 2022
Member
Veykril
left a comment
Veykril
left a comment
There was a problem hiding this comment.
This doesn't only apply use paths, but to all paths, so we should add the is_crate_root check for add_nameref_keywords_with_colon to all of them, or rather, we should make is_crate_root a propery of CompletionContext and then just check for that inside add_nameref_keywords_with_colon without passing an extra bool
feniljain
force-pushed
the
fix_completions
branch
2 times, most recently
from
817240a to
b2c9ecf
Compare
Veykril
reviewed
Jun 3, 2022
Contributor
|
☔ The latest upstream changes (presumably #12459) made this pull request unmergeable. Please resolve the merge conflicts. |
feniljain
force-pushed
the
fix_completions
branch
from
b2c9ecf to
a93633b
Compare
feniljain
force-pushed
the
fix_completions
branch
from
a93633b to
0c03de6
Compare
Veykril
reviewed
Jun 10, 2022
Contributor
|
☔ The latest upstream changes (presumably #12562) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
I've done some major refactorings to the ide-completion crate, so you might wanna manually port your changes over again instead of rebasing, sorry 😅 |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useerroneously suggestssuper::as a completion option even when it's not valid. #12439