Remove unused dependencies#2002
Conversation
|
|
||
| # ideally, `serde` should be enabled by `ra_lsp_server`, but we enable it here | ||
| # to reduce number of compilations | ||
| smol_str = { version = "0.1.12", features = ["serde"] } |
There was a problem hiding this comment.
This I think should stay, precisely to enable the serde feature of the smol_str
There was a problem hiding this comment.
Right, I missed that this crate transitively depends on smol_str.
| smol_str = "0.1.9" | ||
| # ideally, `serde` should be enabled by `ra_lsp_server`, but we enable it here | ||
| # to reduce number of compilations | ||
| smol_str = { version = "0.1.12", features = ["serde"] } |
|
bors r+
Thanks!
…On Mon, 14 Oct 2019 at 13:59, Shotaro Yamada ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In crates/ra_syntax/Cargo.toml
<#2002 (comment)>
:
> @@ -15,10 +15,6 @@ rustc-hash = "1.0.1"
arrayvec = "0.4.10"
once_cell = "1.2.0"
-# ideally, `serde` should be enabled by `ra_lsp_server`, but we enable it here
-# to reduce number of compilations
-smol_str = { version = "0.1.12", features = ["serde"] }
Right, I missed that this crate transitively depends on smol_str.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2002>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANB3M6ZQ6TL24Z3ZST5KY3QORGJNANCNFSM4JAABRSA>
.
|
Build succeeded |
|
Maybe it's a stupid question, but what's that thing about |
|
If you |
|
But why not |
|
I think that would cause the same effect |
|
Ah, you're right 😕. I thought it would use the same features as requested by the entire workspace, not only by that crate in isolation. |
3 participants
No description provided.