minor: Option-box crate_lang_items query result
#21171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Contributor
|
Is there a reason you disagree with what I said in #21149 (comment)? |
Member
Author
|
Oh, meant to put that into the description, sorry (got interruped while drafting the PR). While its really not that much (on a 1500 crate workspace this will amount to ~2mb), the diff itself is so simple (+8 −4) that I do think its worth it to optimize here. We can't only chase big memory gains, at some point we will only be left with these little wins. |
lnicola
approved these changes
Dec 1, 2025
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #21149 (comment)