Fix not complete 'else' before tuple #21495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
approved these changes
Jan 26, 2026
| non_trivia_sibling(node.into(), Direction::Prev).and_then(NodeOrToken::into_node); | ||
| iter::successors(prev_sibling, |it| it.last_child_or_token()?.into_node()) | ||
| let Some(prev_token) = previous_non_trivia_token(node) else { return false }; | ||
| iter::successors(prev_token.parent(), |it| it.parent()) |
Contributor
There was a problem hiding this comment.
Suggested change
| iter::successors(prev_token.parent(), |it| it.parent()) | |
| prev_token.parent_ancestors() |
A4-Tacks
force-pushed
the
comp-else-before-tuple
branch
from
b447f9a to
af8bb81
Compare
Example
---
```rust
fn foo() -> (i32, i32) {
if foo {} el$0
(2, 3)
}
```
**Before this PR**
```rust
...
kw crate::
kw false
kw for
...
```
**After this PR**
```rust
...
kw crate::
kw else
kw else if
kw false
kw for
...
```
A4-Tacks
force-pushed
the
comp-else-before-tuple
branch
from
af8bb81 to
cc725f8
Compare
ChayimFriedman2
approved these changes
Jan 26, 2026
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example
Before this PR
After this PR