fix: Fix incorrect continue for convert_range_for_to_while #21514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Example
---
```rust
fn foo() {
$0for mut i in 3..7 {
foo(i);
continue;
bar(i);
}
}
```
**Before this PR**
This may cause an infinite loop
```rust
fn foo() {
let mut i = 3;
while i < 7 {
foo(i);
continue;
bar(i);
i += 1;
}
}
```
**After this PR**
```rust
fn foo() {
let mut i = 3;
while i < 7 {
'cont: {
foo(i);
break 'cont;
bar(i);
}
i += 1;
}
}
```
A4-Tacks
force-pushed
the
range-for-to-while-handle-continue
branch
from
ef3e7fe to
3a842dc
Compare
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example
Before this PR
This may cause an infinite loop
After this PR