fix: generate method assist uses enclosing impl block instead of first found#21684
Merged
A4-Tacks merged 3 commits intorust-lang:masterfrom Feb 21, 2026
Conversation
A4-Tacks
reviewed
Feb 21, 2026
A4-Tacks
approved these changes
Feb 21, 2026
Contributor
Author
|
Thank you for merging .Sorry about that in convenience . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21550
Problem
When using the "Generate method" assist from inside an impl block,
the generated method was always appended to the first impl block
found for that type, instead of the impl block where the cursor is.
For example, given:
The generated
method2was incorrectly inserted into the firstimpl Fooblock instead of the one containing the cursor.Fix
In
gen_method, before falling back toget_adt_source, we nowcheck if the cursor is already inside an impl block for the target
type. If so, we use that impl block as the insertion target.
Test
Added a test case
generate_method_uses_current_impl_blockthatreproduces the issue and verifies the fix.