fix: Not suggest name in nested type in variant#21927
Merged
ChayimFriedman2 merged 1 commit intorust-lang:masterfrom Apr 3, 2026
Merged
fix: Not suggest name in nested type in variant#21927ChayimFriedman2 merged 1 commit intorust-lang:masterfrom
ChayimFriedman2 merged 1 commit intorust-lang:masterfrom
Conversation
Example
---
```rust
struct Other;
struct Vec<T>(T);
enum Foo {
Vec(Vec<$0>)
}
```
**Before this PR**
```text
st Vec<…> Vec<{unknown}> [name]
en Foo Foo []
st Other Other []
sp Self Foo []
```
**After this PR**
```text
en Foo Foo []
st Other Other []
sp Self Foo []
st Vec<…> Vec<{unknown}> []
```
rustbot
added
the
S-waiting-on-review
| ast::Variant(it) => { | ||
| let is_simple_field = |field: ast::TupleField| { | ||
| let Some(ty) = field.ty() else { return true }; | ||
| matches!(ty, ast::Type::PathType(_)) && ty.generic_arg_list().is_none() |
Contributor
There was a problem hiding this comment.
This will mean we'll also not suggest on Foo($0<>); do you think we should suggest on that?
Member
Author
There was a problem hiding this comment.
I don't think it's necessary, this kind of completion is rare
ChayimFriedman2
approved these changes
Apr 3, 2026
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial of #21892
Example
Before this PR
After this PR