fix: offer 'type_mismatch' some fixes inside macro#21952
Open
A4-Tacks wants to merge 1 commit intorust-lang:masterfrom
Open
fix: offer 'type_mismatch' some fixes inside macro#21952A4-Tacks wants to merge 1 commit intorust-lang:masterfrom
A4-Tacks wants to merge 1 commit intorust-lang:masterfrom
Conversation
- Supports macro for `add_missing_ok_or_some` and `str_ref_to_owned`
Example
---
```rust
macro_rules! identity { ($($t:tt)*) => ($($t)*) }
identity! {
fn test() -> String {
"a"$0
}
}
```
**Before this PR**
Invalid trigger range and edit range
**After this PR**
```rust
macro_rules! identity { ($($t:tt)*) => ($($t)*) }
identity! {
fn test() -> String {
"a".to_owned()
}
}
```
---
```rust
macro_rules! identity { ($($t:tt)*) => ($($t)*) }
identity! {
fn div(x: i32, y: i32) -> Result<i32, ()> {
if y == 0 { return Err(()); }
x / y$0
}
}
```
**Before this PR**
Invalid trigger range and edit range
**After this PR**
```rust
macro_rules! identity { ($($t:tt)*) => ($($t)*) }
identity! {
fn div(x: i32, y: i32) -> Result<i32, ()> {
if y == 0 { return Err(()); }
Ok(x / y)
}
}
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add_missing_ok_or_someandstr_ref_to_ownedExample
Before this PR
Invalid trigger range and edit range
After this PR
Before this PR
Invalid trigger range and edit range
After this PR