fix: enhance part of onEnter#21957
Merged
ChayimFriedman2 merged 1 commit intorust-lang:masterfrom Apr 6, 2026
Merged
Conversation
rustbot
added
the
S-waiting-on-review
There was a problem hiding this comment.
Pull request overview
This PR expands onEnter indentation support beyond comment continuation, adding indentation behavior for additional brace-delimited syntactic constructs and updating contributor documentation accordingly.
Changes:
- Update
onEnterimplementation to indent after{for single-line module item lists and broaden/centralize brace-list indentation logic. - Adjust block indentation logic to support empty blocks and refactor “contents end” calculation.
- Update docs to reflect the now partially implemented indentation behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/book/src/contributing/lsp-extensions.md | Updates documentation to reflect newly supported onEnter indentation cases. |
| crates/ide/src/typing/on_enter.rs | Adds indentation support for module item lists, enables empty-block indentation, and refactors brace-list indentation into a shared helper with updated tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ChayimFriedman2
requested changes
Apr 5, 2026
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
ChayimFriedman2
requested changes
Apr 6, 2026
ChayimFriedman2
approved these changes
Apr 6, 2026
detect {$0}
reduce reduction
update based on comment
clippy
ChayimFriedman2
approved these changes
Apr 6, 2026
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
improve some onEnter handling, now it supports some more cases.