Skip to content

internal: add workflow to handle generating lints#21988

Merged
lnicola merged 1 commit intorust-lang:masterfrom
dybucc:ci-generated-lints
Apr 8, 2026
Merged

internal: add workflow to handle generating lints#21988
lnicola merged 1 commit intorust-lang:masterfrom
dybucc:ci-generated-lints

Conversation

@dybucc
Copy link
Copy Markdown
Contributor

@dybucc dybucc commented Apr 7, 2026

As mentioned in #21947.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 7, 2026
@dybucc dybucc force-pushed the ci-generated-lints branch from 288bcc2 to 747bf9b Compare April 8, 2026 06:04
@rustbot

This comment has been minimized.

@lnicola
Copy link
Copy Markdown
Member

lnicola commented Apr 8, 2026

I think I'd be more comfortable going through a PR for this, but it might require additional permissions.

Also, no automated commits on Sunday evening, please.

@dybucc
Copy link
Copy Markdown
Contributor Author

dybucc commented Apr 8, 2026

I opened a PR just for this [1], and it seemed like there was somebody (at
least) mildly interested in having lint generation automated [2]. If it's
worth merging, what schedule should the workflow run through?

@lnicola
Copy link
Copy Markdown
Member

lnicola commented Apr 8, 2026

Any other day is fine, but releases happen Monday morning, so Sunday night is the worst possible time.

It's good to have a workflow to automate this, my point is that it would be better if the workflow opened a pull request instead of committing directly to the repo. It can be automated, but I don't know if the workflow token work for filing PRs.

@dybucc dybucc force-pushed the ci-generated-lints branch from 747bf9b to 46ee2a4 Compare April 8, 2026 15:24
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 8, 2026

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@dybucc dybucc force-pushed the ci-generated-lints branch from 46ee2a4 to 8523117 Compare April 8, 2026 15:25
@lnicola
Copy link
Copy Markdown
Member

lnicola commented Apr 8, 2026

Can we try something like gh pr create --title ... --body ... --label ... instead of that action? It should be the same wrt. permissions.

@lnicola
Copy link
Copy Markdown
Member

lnicola commented Apr 8, 2026

Actually never mind, that action has other nice features like updating an existing PR. But please pin it by hash, e.g. peter-evans/create-pull-request@c0f553fe549906ede9cf27b5156039d195d2ece0 # v8.1.0.

@dybucc dybucc force-pushed the ci-generated-lints branch from 8523117 to d3d5b01 Compare April 8, 2026 15:39
run: cargo codegen lint-definitions

- name: Submit PR
uses: peter-evans/create-pull-request@c0f553fe549906ede9cf27b5156039d195d2ece0
Copy link
Copy Markdown
Member

@lnicola lnicola Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

View changes since the review

Suggested change
uses: peter-evans/create-pull-request@c0f553fe549906ede9cf27b5156039d195d2ece0
uses: peter-evans/create-pull-request@c0f553fe549906ede9cf27b5156039d195d2ece0 # v8.1.0

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Force-pushed anew to avoid having a different commit only for the comment.

@dybucc dybucc force-pushed the ci-generated-lints branch from d3d5b01 to fe3a221 Compare April 8, 2026 15:42
@lnicola
Copy link
Copy Markdown
Member

lnicola commented Apr 8, 2026

I suspect this won't work, but let's see.

@lnicola lnicola added this pull request to the merge queue Apr 8, 2026
Merged via the queue into rust-lang:master with commit 8c5af72 Apr 8, 2026
17 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants