internal: add workflow to handle generating lints#21988
internal: add workflow to handle generating lints#21988lnicola merged 1 commit intorust-lang:masterfrom
Conversation
288bcc2 to
747bf9b
Compare
This comment has been minimized.
This comment has been minimized.
|
I think I'd be more comfortable going through a PR for this, but it might require additional permissions. Also, no automated commits on Sunday evening, please. |
|
Any other day is fine, but releases happen Monday morning, so Sunday night is the worst possible time. It's good to have a workflow to automate this, my point is that it would be better if the workflow opened a pull request instead of committing directly to the repo. It can be automated, but I don't know if the workflow token work for filing PRs. |
747bf9b to
46ee2a4
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
46ee2a4 to
8523117
Compare
|
Can we try something like |
|
Actually never mind, that action has other nice features like updating an existing PR. But please pin it by hash, e.g. |
8523117 to
d3d5b01
Compare
.github/workflows/gen-lints.yml
Outdated
| run: cargo codegen lint-definitions | ||
|
|
||
| - name: Submit PR | ||
| uses: peter-evans/create-pull-request@c0f553fe549906ede9cf27b5156039d195d2ece0 |
There was a problem hiding this comment.
| uses: peter-evans/create-pull-request@c0f553fe549906ede9cf27b5156039d195d2ece0 | |
| uses: peter-evans/create-pull-request@c0f553fe549906ede9cf27b5156039d195d2ece0 # v8.1.0 |
There was a problem hiding this comment.
Force-pushed anew to avoid having a different commit only for the comment.
d3d5b01 to
fe3a221
Compare
|
I suspect this won't work, but let's see. |
As mentioned in #21947.