Update generated lints

[github-actions]

Weekly lint updates for crates/ide-db/src/generated/lints.rs.

Closes #21947

[lnicola]

CC @dybucc

[dybucc]

I guess it works based on the fact it has a similar diff to the one I submitted
in #21947? I'll close that PR now if this seems satisfactory.

[lnicola]

I'm not at the computer right now, but we might need to adjust the CI workflow, because it didn't fire.

[dybucc]

You mean automatically? I don't think it's meant to run outside the scheduled
Saturday night cron setting, unless a manual workflow run is triggered.

[lnicola]

No, I mean the usual CI workflow: https://github.com/rust-lang/rust-analyzer/blob/master/.github/workflows/ci.yaml. We check for if: github.repository == 'rust-lang/rust-analyzer', but I don't know why that wouldn't work for this PR. It's stuck at conclusion, but the other jobs didn't run.

[ShoyuVanilla]

I guess we should explicitly designate token as sth other than default GITHUB_TOKEN?
https://github.com/peter-evans/create-pull-request?tab=readme-ov-file#token

[lnicola]

Would that help? The workflow filed the PR, so I don't think it's a permissions issue.

[ShoyuVanilla]

Yeah, AFAIK everything triggered with GITHUB_TOKEN cannot trigger CI

[ShoyuVanilla]

To elaborate more,

• Creating PRs/commits with GITHUB_TOKEN have no problem
• But they can't trigger GH Actions

[lnicola]

We've lost our Clippy lints.

[dybucc]

Not really sure what you mean, beyond the fact that the
workflows-rust-analyzer bot seems to have taken over the PR, and that the
apparent fix in #22004 has been discarded, for some reason.

[lnicola]

The URL at

rust-analyzer/xtask/src/codegen/lints.rs

Line 86 in ddae703

"curl https://rust-lang.github.io/rust-clippy/stable/lints.json --output {lints_json}"

is now a 404, which causes at least one test (hover_clippy_lint) to fail, because it no longer finds the lint. I didn't check your branch, but the diff here has:

+pub const CLIPPY_LINTS: &[Lint] = &[];
+pub const CLIPPY_LINT_GROUPS: &[LintGroup] = &[];

cargo codegen doesn't complain because the code is not using curl -f.

[dybucc]

Then I guess this PR is unrelated to this issue. Still, it seems like the
gh-pages branch in clippy's repo had the lints.json file removed from beta
on March 6th [1], so maybe it's been altogether removed and clippy lints have
to be fetched in some other way.

[lnicola]

View changes since the review

Changed this to take the last working version.

[ShoyuVanilla]

Not really sure what you mean, beyond the fact that the workflows-rust-analyzer bot seems to have taken over the PR, and that the apparent fix in #22004 has been discarded, for some reason.

That PR was wrong and #22011 does the thing correctly 😅