fix: complete variants of hidden enums through public aliases#22003
Merged
A4-Tacks merged 1 commit intorust-lang:masterfrom Apr 13, 2026
Merged
fix: complete variants of hidden enums through public aliases#22003A4-Tacks merged 1 commit intorust-lang:masterfrom
A4-Tacks merged 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
A4-Tacks
requested changes
Apr 12, 2026
| pub type Bar = Foo; | ||
|
|
||
| fn main() { | ||
| let x = Bar::V$0; |
Member
There was a problem hiding this comment.
This test is invalid, you need to reference it in another crate
A4-Tacks
reviewed
Apr 12, 2026
| } | ||
| e.variants(ctx.db) | ||
| .into_iter() | ||
| .filter(|&variant| ctx.check_stability_and_hidden(variant)) |
Member
There was a problem hiding this comment.
This check is redundant, it already exists in add_enum_variant
A4-Tacks
requested changes
Apr 12, 2026
Fixes rust-lang#21891. Previously, the completion engine would aggressively bail out if the parent enum was marked . This pushes the visibility check down to the individual variants so they can be properly completed when accessed via a public type alias.
Amit5601
force-pushed
the
fix/hidden-enum-clean
branch
from
6685b15 to
9704b3f
Compare
A4-Tacks
approved these changes
Apr 13, 2026
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21891.
Previously, the completion engine would aggressively bail out if the parent enum was marked . This pushes the visibility check down to the individual variants so they can be properly completed when accessed via a public type alias.