Fix rustfmt relative custom command#22010
Merged
Veykril merged 1 commit intorust-lang:masterfrom Apr 11, 2026
Merged
Conversation
When `rustfmt.overrideCommand` is a relative path, it's joined with the workspace root to make it an absolute path. Without this the command path can't be resolved, especially because rustfmt changes the cwd to make sure rustfmt.toml works correctly. Currently `run_rustfmt` only does this when it finds a `target_spec` using `target_spec_for_file` which only works for the root file of the target. This commit changes it to use `TargetSpec::from_file` which works for any file in the crate.
rustbot
added
the
S-waiting-on-review
Contributor
Author
|
Looking at this code path a bit closer, I actually think maybe we don't need to find the target_spec at all. The code path tries to find a sensible root even if the file is not part of any target, so limiting formatting to files that are part of a target feel unnecessary here. See erfanio@abd932c0bb |
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
rustfmt.overrideCommandis a relative path, it's joined with the workspace root to make it an absolute path. Without this the command path can't be resolved, especially because rustfmt changes the cwd to make sure rustfmt.toml works correctly.Currently
run_rustfmtonly does this when it finds atarget_specusingtarget_spec_for_filewhich only works for the root file of the target.This commit changes it to use
TargetSpec::for_filewhich works for any file in the crate.