feat: add .new postfix completion based on expected type (rust-lang/r…#22132
Merged
A4-Tacks merged 1 commit intorust-lang:masterfrom Apr 23, 2026
Merged
feat: add .new postfix completion based on expected type (rust-lang/r…#22132A4-Tacks merged 1 commit intorust-lang:masterfrom
A4-Tacks merged 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-review
A4-Tacks
reviewed
Apr 22, 2026
| postfix_snippet("call", "function(expr)", &format!("${{1}}({receiver_text})")) | ||
| .add_to(acc, ctx.db); | ||
| if let Some(expected_ty) = ctx.expected_type.as_ref() { | ||
| let ty_name = expected_ty.display(ctx.db, ctx.display_target).to_string(); |
Member
There was a problem hiding this comment.
In an ideal situation, this should determine whether there is a new method, if there is one parameter, and if the types match
Amit5601
force-pushed
the
feat-postfix-new
branch
from
a3e74d2 to
34d2f6e
Compare
Amit5601
force-pushed
the
feat-postfix-new
branch
from
34d2f6e to
71dcae2
Compare
rustbot
added
the
S-waiting-on-review
A4-Tacks
approved these changes
Apr 23, 2026
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20851
Added a .new postfix completion to easily construct types when the expected type is known.
Added the postfix_new unit test to verify it triggers correctly.