perf: Provide access to RootDatabase's LineIndex for the proc macro protocol#22191
Merged
Conversation
…tocol Instead of recreating it.
rustbot
added
the
S-waiting-on-review
Shourya742
reviewed
May 14, 2026
|
|
||
| Ok(SubResponse::SourceTextResult { text }) | ||
| } | ||
| // Not incremental: requires building line index. |
Member
There was a problem hiding this comment.
This line can be removed now.
Member
There was a problem hiding this comment.
Well, its still not incremental tbf
Member
There was a problem hiding this comment.
TBH, I didn’t read the ‘not incremental’ part :P. I was referring to the second part of the statement, considering we’re no longer rebuilding it every time.
Non-blocker though.
Veykril
approved these changes
May 14, 2026
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of recreating it.