ide-diagnostics: emit error for duplicate field in record expression#22235
Merged
ChayimFriedman2 merged 2 commits intorust-lang:masterfrom May 4, 2026
Merged
Conversation
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
ChayimFriedman2
approved these changes
May 1, 2026
Contributor
|
You will also need to rebase against master. |
MavenRain
force-pushed
the
fixme-duplicate-field-diagnostic
branch
from
716b99f to
8c7e4d9
Compare
This comment has been minimized.
This comment has been minimized.
Resolves a FIXME at hir-ty/src/infer/expr.rs that allowed
record expressions like `S { foo: 1, foo: 2 }` to type-check
with no error. Adds an InferenceDiagnostic::DuplicateField
variant, plumbs the cooked diagnostic through hir, and renders
it as RustcHardError E0062 ("field specified more than once").
Tests: struct literal positive, enum variant literal positive,
single-occurrence negative, no-conflict with the existing
no-such-field path.
Part of rust-lang#22140.
MavenRain
force-pushed
the
fixme-duplicate-field-diagnostic
branch
from
8c7e4d9 to
5e757fd
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
ChayimFriedman2
requested changes
May 3, 2026
| #[derive(Debug)] | ||
| pub struct DuplicateField { | ||
| pub field: InFile<AstPtr<Either<ast::RecordExprField, ast::RecordPatField>>>, | ||
| pub variant: VariantId, |
Contributor
There was a problem hiding this comment.
Should be hir::Variant. Do not expose hir-ty types outside hir.
Per review: do not expose hir-ty/hir-def types outside hir. Convert the lower-level VariantId to the public Variant wrapper at the inference-diagnostic boundary.
ChayimFriedman2
approved these changes
May 4, 2026
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a FIXME at hir-ty/src/infer/expr.rs that allowed record expressions like
S { foo: 1, foo: 2 }to type-check with no error.Adds an InferenceDiagnostic::DuplicateField variant, plumbs the cooked diagnostic through hir, and renders it as RustcHardError E0062 ("field specified more than once").
Tests: struct literal positive, enum variant literal positive, single-occurrence negative, no-conflict with the existing no-such-field path.
Part of #22140.