fix: improve whitespaces for trait item complete#22240
Merged
ChayimFriedman2 merged 1 commit intorust-lang:masterfrom May 2, 2026
Merged
fix: improve whitespaces for trait item complete#22240ChayimFriedman2 merged 1 commit intorust-lang:masterfrom
ChayimFriedman2 merged 1 commit intorust-lang:masterfrom
Conversation
Example
---
```rust
trait SomeTrait<T> {}
trait Foo<T> {
fn function()
where Self: SomeTrait<T>;
}
impl Foo<u32> for Bar {
fn f$0
}
```
**Before this PR**
```rust
impl Foo<u32> for Bar {
fn function()
where Self: SomeTrait<u32> {
$0
}
}
```
**After this PR**
```rust
impl Foo<u32> for Bar {
fn function()
where Self: SomeTrait<u32>
{
$0
}
}
```
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
approved these changes
May 2, 2026
| impl Foo<u32> for Bar { | ||
| fn function() | ||
| where Self: SomeTrait<u32> { | ||
| where Self: SomeTrait<u32> |
Contributor
There was a problem hiding this comment.
Do you think we should implement in tests the editor functionality that inserts indentation?
Member
Author
There was a problem hiding this comment.
This may require adding the concept of 'main edit' for test
I don't think it's necessary
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example
Before this PR
After this PR