Backwards compatible CompletionImport#as_underscore#22284
Merged
ChayimFriedman2 merged 2 commits intorust-lang:masterfrom May 4, 2026
Merged
Backwards compatible CompletionImport#as_underscore#22284ChayimFriedman2 merged 2 commits intorust-lang:masterfrom
ChayimFriedman2 merged 2 commits intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
xitep
added a commit
to xitep/lsp-mode
that referenced
this pull request
May 4, 2026
ChayimFriedman2
approved these changes
May 4, 2026
rustbot
removed
the
S-waiting-on-review
This was referenced May 4, 2026
Member
|
not the first time we had to fix this emacs bug on our side |
xitep
added a commit
to xitep/lsp-mode
that referenced
this pull request
May 5, 2026
jcs090218
pushed a commit
to emacs-lsp/lsp-mode
that referenced
this pull request
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit f42e02aa introduced a new, required field which breaks auto-import in emacs in the very same fashion as issue #18767.
This PR makes the field optional; it does not, however, fix the issue per se for emacs users since
lsp-modestill sends anull.