fix: show Run lens for fn main in bench targets#22357
Merged
Merged
Conversation
`request.rs` was passing `binary_target = true` for TargetKind::Bin, Example, and Test, but not for Bench, so a `fn main()` in `benches/foo.rs` (typical with `harness = false`) was suppressed by `should_skip_runnable` in the annotations layer. Mirror `target_spec.rs:255` by including Bench in both the code-lens config check and `should_skip_target`. Closes rust-lang#21948. Signed-off-by: Onyeka Obi <softwareengineerasaservant@isurvivable.cv>
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
approved these changes
May 14, 2026
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crates/rust-analyzer/src/handlers/request.rsenumeratesTargetKind::Bin | TargetKind::Example | TargetKind::Testin two places (code-lens annotation config at line 1660 andshould_skip_targetat line 2341) but omitsTargetKind::Bench. The existing analogous list intarget_spec.rs:255does includeBench, so this looks like a copy-paste oversight. Result: afn main()inbenches/*.rswithharness = falseproduces aRunnableKind::Binrunnable, but the annotation layer'sshould_skip_runnableskips it because the LSP config passesbinary_target = falsefor bench targets.Closes #21948.