fix(hir-ty): saturate float-to-uint cast in const eval#22430
Merged
lnicola merged 1 commit intoMay 23, 2026
Merged
Conversation
lnicola
approved these changes
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22429.
Summary
crates/hir-ty/src/mir/eval.rsFloatToIntcast path: the unsigned upper bound was1i128 << dest_bitsinstead of(1i128 << dest_bits) - 1, breaking symmetry with the signed branch directly above it.256.0f32 as u8,(1./0.) as u8,1e10f32 as u16) was evaluated as0instead of saturating tou_N::MAX.rustcis unaffected (saturating float casts are stable since Rust 1.45).How to reproduce
cargo run(real rustc)Xconst X: u8 = 0❌const X: u8 = 255✓0❌255✓255✓Signed casts (e.g.
256.0f32 as i8) are unaffected — the signed branch was already correct.Root cause
For
u8(dest_bits = 8), the buggy upper bound is256. The clamp.min(256)keeps the value as256(or anything ≥ 256). Then256.to_le_bytes()[0..1] = [0]because256 = 0x100and the low byte is0. The function therefore returns0instead of255.🤖 Spotted via AI-assisted code review.